This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
feat(cli): add socket-path flag to runner install #4246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@Codelax is attempting to deploy a commit to the HashiCorp Team on Vercel. A member of the Team first needs to authorize it. |
paladin-devops
approved these changes
Dec 9, 2022
There was a problem hiding this comment.
Looks good to me! Tried this with the flag used and without, both worked. 😄
$ waypoint runner install -platform=docker -server-addr=<ADDR> -server-tls-skip-verify=true -server-tls=true$ waypoint runner install -platform=docker -docker-socket-path=/var/run/docker.sock -server-addr=<ADDR> -server-tls-skip-verify=true -server-tls=true
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a socket-path flag to
waypoint runner install, this allows to override the socket that will be bound using volume when creating the runner.The issue is that docker socket may not be
/var/run/docker.sockon the server that will host the runner, this would be in another place when running rootless docker for example.This also helps greatly to start runners when using podman (ref: #3781).