Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Core: Ensure Project and Workspace names are valid #4588

Merged
merged 4 commits into from
Mar 29, 2023

Conversation

briancain
Copy link
Member

Prior to this commit, users could create project names like "." or even
" ". This commit tightens up those rules to only allow for
alpha-numberic characters, as well as underscore and hyphens. All other
characters are not valid for projects.

Fixes #4572
Fixes #4571

Prior to this commit, users could create project names like "." or even
"   ". This commit tightens up those rules to only allow for
alpha-numberic characters, as well as underscore and hyphens. All other
characters are not valid for projects.

Fixes #4572
Ensure a workspace name is valid and not empty, only alpha-numberic like
projects.

Fixes #4571
@briancain briancain added pr/no-changelog No automatic changelog entry required for this pull request backport/0.11.x labels Mar 24, 2023
@briancain briancain requested a review from a team March 24, 2023 18:22
@briancain briancain requested a review from a team as a code owner March 24, 2023 18:22
@briancain briancain removed the pr/no-changelog No automatic changelog entry required for this pull request label Mar 24, 2023
@github-actions github-actions bot added the core label Mar 24, 2023
@briancain briancain added the bug Something isn't working label Mar 24, 2023
@briancain briancain requested review from a team, xiaolin-ninja and paladin-devops and removed request for a team March 27, 2023 15:28
Copy link
Contributor

@paladin-devops paladin-devops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@briancain briancain merged commit 1abd580 into main Mar 29, 2023
@briancain briancain deleted the b/server/enforce-good-names-projects-workspaces branch March 29, 2023 17:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/0.11.x bug Something isn't working core
Projects
None yet
2 participants