This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
cli: Introduce an editor class for in-terminal edits, add waypoint runner profile edit command
#4594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit brings in a basic Editor set of functionality to allow various CLI commands to directly editor HCL configs rather than requiring lots of CLI flags. Commands can launch their own editor, which will place a temp file on disk, and return the resulting edited bytes back to be saved or submitted as the updated config
This command makes use of the new editor package, and will edit configs in place and submit that config up to the server.
briancain
added
pr/no-changelog
briancain
removed
the
pr/no-changelog
evanphx
suggested changes
Mar 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit brings in a basic Editor set of functionality to allow
various CLI commands to directly editor HCL configs rather than
requiring lots of CLI flags. Commands can launch their own editor, which
will place a temp file on disk, and return the resulting edited bytes
back to be saved or submitted as the updated config
Additionally, this pull request implements this new editor class by introducing
a new command
waypoint runner profile editwhere you can edit a runnerprofiles plugin config directly in your editor without having to pass through
an existing config file on disk.
Fixes #4427