This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
internal: Cleanup remote URL trimming for git #4675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, it was possible to craft a bad git remote and bypass our normalize func for remote git URLs. TrimLeft and TrimRight remote all occurances of the given pattern. The intention however is to only remove the first instance of `git@` and the last instance of `.git` from the given url. This commit fixes that by updating the string trimmers to use TrimPrefix and TrimSuffix, which will only remove the single instance of the pattern. Fixes WAYP-1173
briancain
added
pr/no-changelog
briancain
removed
the
pr/no-changelog
catsby
approved these changes
May 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, it was possible to craft a bad git remote and bypass our normalize func for remote git URLs. TrimLeft and TrimRight remote all occurances of the given pattern. The intention however is to only remove the first instance of
git@and the last instance of.gitfrom the given url. This commit fixes that by updating the string trimmers to use TrimPrefix and TrimSuffix, which will only remove the single instance of the pattern.Fixes WAYP-1173