This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
ECS bug fixes and improvements #4742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paladin-devops
added
plugin/ecs
ecosystem
…col and version. Prior to this commit, only the HTTP protocol was supported. Users of applications which require other protocols, or other protocol versions, such as gRPC, are now supported. A bug was also fixed, where the user-specified health check protocol was previously being set to the target group protocol, instead of the health check's.
Upgrade AWS SDK version as well.
…ed when destroying a target group.
paladin-devops
force-pushed
the
i-ecs-target-group-protocol
branch
from
67d0803
to
f0ead66
Compare
paladin-devops
commented
May 24, 2023
| "target_group_protocol", | ||
| "The protocol to use for routing traffic to the targets.", | ||
| docs.Default("HTTP"), | ||
| docs.Summary("The protocol to use for routing traffic to the targets. "+ |
There was a problem hiding this comment.
I pulled the descriptions for these two fields from the AWS docs - I wasn't sure if that was kosher for our docs, so if it's not, happy to change!
… target group health.
paladin-devops
force-pushed
the
i-ecs-target-group-protocol
branch
from
f0ead66
to
5b2a3bc
Compare
Prior to this commit, the ALB would be deleted even if Waypoint did not create it.
paladin-devops
force-pushed
the
i-ecs-target-group-protocol
branch
from
d4026d7
to
a0b41bd
Compare
izaaklauer
approved these changes
May 25, 2023
catsby
reviewed
May 25, 2023
Co-authored-by: Clint <catsby@users.noreply.github.com>
|
Fixes #4745 |
|
Hey @paladin-devops are we good to go here with this PR? I believe it fixes an existing bug in 0.11.1 |
|
@catsby I just pushed another update which should fix the failing Go test, and addressed your last open feedback. We'll be good to go after checks pass. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was originally intended for adding an improvement which enables the user to set the target group protocol and protocol version for an AWS ECS deployment. However, it also adds some logging and fixes some bugs!
grpc_codeorhttp_codeinside thehealth_checkblock for the AWS ECS deployment plugin, the plugin would panic - this is fixed by setting theMatcherfield of theCreateTargetGroupInputstruct to an empty struct of the typeMatcher.elasticloadbalancing:DescribeTargetHealth- this has been added!waypoint_managedand it is set totrue, then the ALB will be deleted on when a destroy job runs.