This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
internal/config: Remove redundant context append for parsing #4744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, if a config had many pipeline stanzas, say more than 6, each time we would parse a pipeline via the hcl EvalContext we would append that context to the current one to capture any additional parts of the config. Given that we are evaluating the entire config file and not parts of it, this action was redundant. Additionally, it made parsing many pipeline configs slow for each appended context. This fixes it by removing the append. We don't need to append this, given we have the full config context each time we parse pipelines.
briancain
added
pr/no-changelog
briancain
removed
the
pr/no-changelog
jgwhite
previously approved these changes
May 25, 2023
jgwhite
dismissed
their stale review
Jumped the gun — there are still test failures.
jgwhite
approved these changes
May 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, if a config had many pipeline stanzas, say more than 6, each time we would parse a pipeline via the hcl EvalContext we would append that context to the current one to capture any additional parts of the config. Given that we are evaluating the entire config file and not parts of it, this action was redundant. Additionally, it made parsing many pipeline configs slow for each appended context.
This fixes it by removing the append. We don't need to append this, given we have the full config context each time we parse pipelines.
Thank you @jgwhite and @sdav9375 for identifying this!