This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
server,cli: Add explicit delete RPC and CLI endpoints for Config and ConfigSourcers + tests
#4754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briancain
added
the
pr/no-changelog
briancain
removed
the
pr/no-changelog
briancain
force-pushed
the
f/cfg-cfgsrcs/explicit-endpoints
branch
from
38de2fd
to
d87eb52
Compare
evanphx
approved these changes
Jun 1, 2023
This commit introduces a simple ConfigDelete endpoint, which uses the existing ConfigSet endpoint to delete or unset config vars. To make this change as simple as possible, we can still leverage the existing system to unset variables, but introduce a more explicit endpoint for deleting configs.
briancain
force-pushed
the
f/cfg-cfgsrcs/explicit-endpoints
branch
from
6f485e6
to
1a9852d
Compare
|
Fixed a merge conflict in the server proto gen file. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an explicit delete endpoint for both
ConfigandConfigSourcers. It introduces the RPC endpoints for each, and additionally adds CLI commands for each. It's built on top of the "Unset" flow that already existed to minimize the footprint of this addition to mostly be a front-end change in the API layer.