This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Fix workspace-scoped global config source get requests #4774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, global config source get requests were receiving all config sources at the global scope, even if a workspace was specified. The state function was skipping over the filtering out of config sources which were not for the specified workspace. This commit fixes that, and now global config source requests will filter out config sources which are not in the specified workspace.
paladin-devops
force-pushed
the
config-sourcer-state-tests
branch
from
365baaf
to
69db2c6
Compare
xiaolin-ninja
approved these changes
Jun 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the retrieval of workspace-scoped, globally-scoped config sources. Prior to the changes in this PR, clients were receiving all globally-scoped config sources on a get request, even if they only wanted the config source for a specific workspace. This was because the logic to filter out the results from the other workspaces was being skipped, but that is fixed by this PR.
Added some tests!