This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Nomad runner install CPU and memory flags #4798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paladin-devops
force-pushed
the
b-nomad-runner-install-resource-cli-flags
branch
from
4ec87b6
to
6aed3f4
Compare
briancain
approved these changes
Jun 12, 2023
|
|
||
| set.StringVar(&flag.StringVar{ | ||
| Name: "nomad-runner-memory", | ||
| Target: &i.Config.RunnerResourcesMemory, |
There was a problem hiding this comment.
Weird, did we accidentally delete these install flags or something? Looks like the target var already existed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Nomad runner install configuration has fields for CPU and memory, but no flags for the user to set them - this PR adds those flags. This fix stems from a discussion on HashiCorp Discuss, where a user installing a runner had insufficient resources on their Nomad client to run the runner, and I realized I could not suggest setting lower memory or CPU on the runner because there were no CLI flags to support it.