This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
runnerinstall/aws-ecs: Add AddTags permission to ODR IAM policy. #4818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paladin-devops
force-pushed
the
b-ecs-runner
branch
from
5c1ff64
to
a79fd3e
Compare
The AWS ECS plugin may need to add tags to an AWS ALB, and therefore needs the AddTags permission to do so.
paladin-devops
force-pushed
the
b-ecs-runner
branch
from
6df94d1
to
2625cd7
Compare
catsby
reviewed
Jun 22, 2023
There was a problem hiding this comment.
The AWS ECS plugin may need to add tags to an AWS ALB
May?
This is proposed as a bug fix, but it's described as a optional feature. Is there a situation where without this an error will occur? If possible, we should mention that here incase people are out there looking for issues/PRs related to it. It will also help future reviewers or code spelunking to understand why this change was made
|
@catsby I updated the PR description to indicate the problem that this is fixing! |
izaaklauer
approved these changes
Jul 7, 2023
catsby
approved these changes
Jul 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
AddTagspermission is required when Waypoint manages the ALB resource for the AWS ECS plugin. If the user supplies their own ALB, this permission is not needed, because the plugin won't add a tag to indicate that it's managed by Waypoint.