Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Fix syntax error in ECS policy doc #4873

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Conversation

izaaklauer
Copy link
Contributor

@izaaklauer izaaklauer commented Aug 8, 2023

Closes #4872

Fixes a json syntax error in the ecs inline policy introduced in #4840 by adding a close quote

How can I verify this fix?

Run a waypoint install against an AWS account without a role named waypoint-runner, and verify success:

$ ./waypoint runner install   -platform=ecs   -server-addr=api.hashicorp.cloud:443   -ecs-runner-image=hashicorp/waypoint -ecs-region=us-east-1 -ecs-cluster=waypoint
✓ Finished connecting to: api.hashicorp.cloud:443
✓ Runner "01H7BA4XNXE0Y4CEMEHKFQAK3R" installed successfully to ecs
✓ Runner profile "ecs-01H7BA4XNXE0Y4CEMEHKFQAK3R" created successfully.
✓ Networking setup
✓ EFS ready
✓ Found existing IAM role to use: waypoint-runner-execution-role
✓ Created IAM task role: waypoint-runner
✓ Using existing log group
✓ Runner service created
✓ Runner "01H7BA4XNXE0Y4CEMEHKFQAK3R" adopted successfully.

@izaaklauer
Copy link
Contributor Author

Integration tests are failing, but it seems to be transient, and we've observed this happen on other branches before and then pass on main.

Going to try merging for now. If it fails on main, we'll deal with that in a moment.

@izaaklauer izaaklauer merged commit 50664f6 into main Aug 8, 2023
44 of 45 checks passed
@izaaklauer izaaklauer deleted the fixEcsRunnerIamPolicy branch August 8, 2023 21:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

waypoint runner install -platform=ecs fails due to policy syntax errors
2 participants