Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few questions regarding script #23

Closed
vespuccieth opened this issue Feb 20, 2022 · 2 comments
Closed

Few questions regarding script #23

vespuccieth opened this issue Feb 20, 2022 · 2 comments

Comments

@vespuccieth
Copy link

vespuccieth commented Feb 20, 2022

Is it possible to make that script starts from token #0 instead of #1?

If we don't need hidden png/json, can we just leave environmental variable empty/blank?

Also this is my image url in json file: "image":"http:\/\/tv3-app-vg9pw.ondigitalocean.app\/asset\/1.png"
What's up with \/

Also thank you for this script, this is literally a game changer

@liarco
Copy link
Member

liarco commented Feb 20, 2022

Is it possible to make that script starts from token 0 instead of 1?

Hi @vespuccieth, I'm about to publish a video that shows how you can customize the app to your needs, you will be able to start from there to change any behavior. But as far as I know the ERC721 standard expects token IDs to start from 1. As a developer I would prefer IDs to start from 0 too, but we have to be compliant to that... 😅

I'm gonna drop the link here as soon as I publish the video. 😉

If we don't need hidden png/json, can we just leave environmental variable empty/blank?

Everything should work as expected, but your hidden metadata (if requested by any marketplace) will be invalid. I highly suggest having the hidden metadata/assets anyway to be fully compliant... but it's up to you.

Also this is my image url in json file: "image":"http://tv3-app-vg9pw.ondigitalocean.app/asset/1.png"
What's up with /

The JSON code you are showing is perfectly fine. I know that syntax is a bit uncommon, but it's correct as per JSON specifications.

You can see it trying to paste the following code on https://jsoneditoronline.org:

{
  "image": "http:\/\/tv3-app-vg9pw.ondigitalocean.app\/asset\/1.png"
}

You will see that the \/ chars will be highlighted as an escaped sequence for /.

Also thank you for this script, this is literally a game changer

Thank you so much, I really appreciate it. 🙏

@liarco liarco added the feedback requested To be closed if no feedback is received label Feb 20, 2022
@vespuccieth
Copy link
Author

Great, appreciate it ♥

@liarco liarco mentioned this issue Feb 20, 2022
@liarco liarco removed the feedback requested To be closed if no feedback is received label Feb 20, 2022
@liarco liarco closed this as completed Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants