a bit improvements in the code #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is better to create the hashes list before the for loop because the script does not operate on them, just checks for the existence of a value. When our referenced list elements are lowercase, key and key.lower() are the same. I didn't find lines 59 and 60 useful, because in line 57, the script checks whether the key exists in the list and the value never been empty. (Or perhaps you put them there for future options.)
|
Thank you for the pull-request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
here are some thoughts about my pull request.
hasheslist before the for loop because the script does not operate on them, just checks for the existence of a value.keyandkey.lower()are the same and we don't need both of them.