Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull requests or fork? #18

Open
lyuts opened this issue Mar 24, 2024 · 3 comments
Open

Pull requests or fork? #18

lyuts opened this issue Mar 24, 2024 · 3 comments

Comments

@lyuts
Copy link

lyuts commented Mar 24, 2024

Hi @rudib , I'm lucky to come across your library. It does state machines the way I got used to. I've seen another issue where you say the project is in standby mode as you currently don't have a usecase for it in order to actively maintain it. I'd like to double check whether you'd be open to pull requests, or instead recommend people fork it?

@chmorgan
Copy link

@lyuts happy to see you are picking this library up.

Coming from having used boost::sml in a half dozen commercial projects over the past handful of years I'm a fan of the approach here. Almost all fsm implementations in rust are toy ones, they lack guards, enter/exit, actions etc, things that you need to build fsm based systems. I like this library and I'm excited to see it might continue to be developed.

@rudib
Copy link
Member

rudib commented Apr 13, 2024

Status unchanged, I don't actively require a good FSM library right now.

Taking it to the next level (in my imaginary plan) would probably require a rewrite, one of the main features I'd like to add is async compatibility. It also need a significant update to upgrade to syn version 2.

All in all, maintaining such a complex library is a lot more work than people think.

I'm in favor of forking (and renaming) if it's a significant rebuild. Otherwise, I might be tempted by small PRs.

@lyuts
Copy link
Author

lyuts commented Apr 13, 2024

Thanks for sharing thoughts on future improvements to the library. I can't promise I'll make them, but I'd like to study your implementation and experiment with it. And also, thanks for being open to small PRs. I think we should all be cautious about your time and bother you with important changes only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants