Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not rebuilding dependencies? #88

Closed
noam87 opened this issue Sep 20, 2016 · 4 comments
Closed

Not rebuilding dependencies? #88

noam87 opened this issue Sep 20, 2016 · 4 comments

Comments

@noam87
Copy link

noam87 commented Sep 20, 2016

Hi, so I'm using the ja_serializer gem which requires to be rebuilt after a setting is changed, via mix deps.clean ja_serializer && mix deps.get (https://github.com/AgilionApps/ja_serializer#attribute-relationship-and-query-param-key-format).

Now this does not seem to be working in heroku, So next I tried passing the always_rebuild=true flag to buildpack, but again this did not work (and from the heroku log at least, I can't see that dependencies are being rebuilt).

My fix for this has been to set dependency one version lower, then upgrade again, which will recompile it as expected.

@noam87
Copy link
Author

noam87 commented Sep 20, 2016

I'm not too familiar, but perhaps at

mix deps.get --only $MIX_ENV || exit 1
this would work?:

if [ $always_rebuild = true ]; then
  mix deps.clean --all && mix deps.get --only $MIX_ENV || exit 1
else
  deps.get --only $MIX_ENV || exit 1
fi

Or maybe a separate option for recompiling assets. If so, I can create a PR.

@HashNuke
Copy link
Owner

@noam87 We have support for a pre-compile hook and a post-compile hook. Can you see if these can be used? (examples in the readme)

@ericmj
Copy link
Collaborator

ericmj commented Sep 20, 2016

always_rebuild=true should work, if it doesn't it's a bug. always_rebuild cleans the cache here

function clean_cache() {
.

@HashNuke
Copy link
Owner

Closing since no activity since a solution was recommended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants