Passing options to hlint-run?

[philderbeast]

With hlint-run, I'm able to pass in folders to this action doing the equivalent of:

hlint src/

Using the action how would we pass options like --cpp-define and --cpp-simple?

hlint src/ --cpp-define=WINDOWS=1
hlint test/ --cpp-simple

https://github.com/commercialhaskell/stack/blob/af098aa6a8246960229871228c5ed757e29916ad/.github/workflows/unit-tests.yml#L24-L26

[balacij]

FWIW, I got around this issue by adding them through hlint-bin, e.g., hlint-bin: hlint --hint=code/.hlint.yaml.

[mihaimaruseac]

I completely forgot about this one. I'll try to handle this by July 4th long weekend :)

As a side note, I'm considering deprecating hlint-{setup,run} pair in favor of https://github.com/haskell-actions/hlint-scan but I need to make sure all current users can migrate without being impacted too severely. Can you please take a look and see if you can use hlint-scan instead? Thank you!

[balacij]

For my use case, I need a specific version of hlint, which makes hlint-setup particularly great for me. It doesn't look like hlint-scan is capable of the same, unfortunately.

However, it looks like hlint-scan and hlint-run have the same goal -- run HLint and report using GitHub's reporting features. They just use different reporting methods, from what I gather.

If time/cost is a concern and contributor to deprecation, I certainly wouldn't mind contributing if you can point me in the right direction.

[mihaimaruseac]

Thank you for the reply. Then I won't deprecate this until we can make sure hlint-scan is capable of selecting the hlint version.