-
Notifications
You must be signed in to change notification settings - Fork 88
Improve the performance of filter and lines #332
Comments
at the moment there's no way to go faster because it's using the Prelude implementation of lines and filter. relatively easy fix though. |
could you try running it through conduit just to check for speed difference ? Something like this should workaround the slow perf of String.lines: import Foundation.Conduit.Textual (lines)
runConduit (sinkSource s .| lines .| sinkList) |
Conduit goes way faster - it's now beating the
|
For info, moving to |
I think |
Then you can probably close this issue (although adding a benchmark might be interesting to see the overhead of conduit). |
I ported weeder to foundation. It goes 30% slower compared to
[Char]
, and I was hoping for a significant speedup (that was the entire point of the port). The two most egregious things in the profile are:Namely I spend 39% in lines, and because of #331 I need to add a filter that takes 30% of the time.
The text was updated successfully, but these errors were encountered: