Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of backwards incompatible API changes to do in 1.0 #49

Open
mvdan opened this issue Jan 18, 2018 · 2 comments
Open

List of backwards incompatible API changes to do in 1.0 #49

mvdan opened this issue Jan 18, 2018 · 2 comments

Comments

@mvdan
Copy link
Contributor

mvdan commented Jan 18, 2018

  • Replace as and infer with proxy - Proxy #41
  • Remove setImportsQ in favor of setImportsF
  • Give setImportsF a better name, potentially just replace setImports with it

Open to suggestions - this list can of course be extended. We should try to keep the number of changes small, but at the same time make it worthwhile - as we don't want to introduce other backwards incompatible changes every other year.

I'll release 0.8 soon, so 1.0 could happen sometime this year or next.

@mvdan
Copy link
Contributor Author

mvdan commented Mar 3, 2018

We might want to replace typeChecks with typeChecksWithDetails. The latter is more powerful, as it can be used to both obtain the type, as well as the type checking error. The former simply returns a bool. Having both bloats the API in the long term.

@gelisam
Copy link
Contributor

gelisam commented Dec 28, 2018

One change I would like to make is to replace runStmt with a bindPattern operation. I don't like runStmt's String-based API, I would prefer if we were taking the pattern and the expression to bind to those patterns separately... as two separate strings. Okay, I guess it's only a small improvement over a String-based API :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants