Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please, deprecate AttrSet #1007

Open
Anton-Latukha opened this issue Nov 8, 2021 · 0 comments
Open

Please, deprecate AttrSet #1007

Anton-Latukha opened this issue Nov 8, 2021 · 0 comments

Comments

@Anton-Latukha
Copy link
Collaborator

Anton-Latukha commented Nov 8, 2021 •
edited

In 2 years of work on the project - AttrSet alias that was around not grown on me.

I still prefer seeing HashMap VarName <thing at hand> then implicit AttrSet <set at hand>. I think the contributors & especially newcomers would appreciate not complicating things, HashMap VarName <thing at hand> is a nice type signature & it is easy to reason about it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Anton-Latukha