Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deriving for records where all the fields have a Display instance #51

Closed
JonathanLorimer opened this issue May 15, 2023 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@JonathanLorimer
Copy link
Contributor

It would be nice if you could deriving display instances for records where all the fields have a Display instance

@Kleidukos
Copy link
Collaborator

Indeed.

@Kleidukos Kleidukos added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels May 15, 2023
@JonathanLorimer
Copy link
Contributor Author

@Kleidukos if you have any advice on how to do this, I would be happy to take a run at it. I figure you can probably do it with a deriving via generic (or something to that effect)

@Kleidukos
Copy link
Collaborator

@JonathanLorimer Yes this would be something along the lines of https://github.com/tchoutri/pg-entity/blob/main/src/Database/PostgreSQL/Entity/Types.hs#L87-L173 but it's a pain to understand if you've never done it before. Would you like to pair with me on this? :)

@JonathanLorimer
Copy link
Contributor Author

@Kleidukos I have a solution almost done, will put up a draft PR for your initial review

@Kleidukos
Copy link
Collaborator

Wonderful!

@Kleidukos
Copy link
Collaborator

fixed by #52 thanks again @JonathanLorimer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants