Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onALPNClientSuggest #417

Closed
kazu-yamamoto opened this issue Jan 29, 2020 · 1 comment · Fixed by #440
Closed

onALPNClientSuggest #417

kazu-yamamoto opened this issue Jan 29, 2020 · 1 comment · Fixed by #440
Assignees
Labels

Comments

@kazu-yamamoto
Copy link
Collaborator

The no_application_protocol alert should be sent when a client "application_layer_protocol_negotiation" extension advertises only protocols that the server does not support. The current onALPNClientSuggest does not implement this.

How should we implement this?

  • A) If "" is returned from onALPNClientSuggest, sent the alert.
  • B) If an exception is thrown from onALPNClientSuggest, sent the alert.
  • C) Both.
@ocheron
Copy link
Contributor

ocheron commented Feb 22, 2020

Users should not have to use exceptions in callbacks.
A) seems best alternative if we don't want to change API just for this.

Uncaught exception in user code should trigger interal_error alert (like we have already).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants