Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support text-1.3 (with UTF8 internal encoding) #214

Closed
jberryman opened this issue Aug 24, 2021 · 2 comments · Fixed by #234
Closed

Support text-1.3 (with UTF8 internal encoding) #214

jberryman opened this issue Aug 24, 2021 · 2 comments · Fixed by #234

Comments

@jberryman
Copy link

Just a heads up in light of haskell/text#365

The test suite does not catch that when hashable is compiled with above the Text instances result in a buffer over-read
@phadej
Copy link
Contributor

phadej commented Aug 24, 2021

That's why hashable defines an upper bound on text. I doubt the internal encoding change will be released as text-1.2.x.

@phadej phadej changed the title Test suite is not sensitive to changes text library internals Support text-1.3 (with UTF8 internal encoding) Aug 24, 2021
@phadej
Copy link
Contributor

phadej commented Aug 24, 2021

I renamed the issue. I'll look at it when text patch is merged. Others are free to look sooner.

@Bodigrim Bodigrim mentioned this issue Nov 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support text-2.0
2 participants
@phadej @jberryman