Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't vendor Ranged-sets? #182

Open
Ericson2314 opened this issue Mar 19, 2021 · 2 comments
Open

Don't vendor Ranged-sets? #182

Ericson2314 opened this issue Mar 19, 2021 · 2 comments

Comments

@Ericson2314
Copy link
Collaborator

Ericson2314 commented Mar 19, 2021

Right now, https://hackage.haskell.org/package/Ranged-sets depends on big deps like HUnit and QuickCheck. But I have a PR PaulJohnson/Ranged-sets#4 so there is a flag to disable the arbitrary instances and it just depends on base. At that point, I don't see why we just delete the vendored code and use that instead?

@andreasabel
Copy link
Member

A reason could be that atm, Alex depends only on libraries that ship with GHC (https://wiki.haskell.org/Core_Libraries_Committee#Core_Libraries). This might be a property worth preserving. (But I don't have insight into the GHC build process, for instance.)

@Ericson2314
Copy link
Collaborator Author

Yeah I won't pull the trigger on this until I bring up on ghc-devs. Maybe we could have a flag to either use or not use the vendored part as a stop-gap to track divergence too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants