Make newly-added add-source deps override previously installed versions. #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This solution is also described in a bit more detail here. |
Fixes haskell#1197. This patch is a bit large because it includes several related changes: 1) Remove 'installUseSandbox' from 'InstallFlags' and pass 'useSandbox' as an additional argument instead. 2) Instead of calling 'reinstallAddSourceDeps' from 'installAction', always pass 'SandboxPackageInfo' to 'install'. 3) Set the timestamps of newly-added add-source deps to 0 in the timestamp file. 4) Move the timestamp file update to 'postInstallActions' from 'withModifiedDeps'. This way, the timestamps are updated even when the user runs 'install --only-dependencies' or 'install some-add-source-dep-package-id'.
| Nothing -- FIXME | ||
| globalFlags' configFlags'' configExFlags' installFlags' haddockFlags' | ||
| targets | ||
| -- FIXME: Passing 'SandboxPackageInfo' unconditionally means that 'install' |
There was a problem hiding this comment.
Can you elaborate a bit on this. Are we rebuilding/reinstalling things unnecessarily? That sounds bad.
There was a problem hiding this comment.
No. This means that if some add-source dependency is modified when the user runs cabal install some-package inside a sandbox, it will be reinstalled, even though some-package probably does not depend on it.
|
LGTM |
23Skidoo
added a commit
that referenced
this pull request
May 17, 2013
Make newly-added add-source deps override previously installed versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1197.
This patch is a bit large because it includes several related changes:
Remove
installUseSandboxfromInstallFlagsand passuseSandboxas an additional argument instead.Instead of calling
reinstallAddSourceDepsfrominstallAction, always passSandboxPackageInfotoinstall.Set the timestamps of newly-added add-source deps to 0 in the timestamp file.
Move the timestamp file update to
postInstallActionsfromwithModifiedDeps. This way, the timestamps are updated even when the user runsinstall --only-dependenciesorinstall some-add-source-dep-package-id.