Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cabal upload creates candidate without asking #3931

Closed
edsko opened this issue Oct 3, 2016 · 9 comments
Closed

cabal upload creates candidate without asking #3931

edsko opened this issue Oct 3, 2016 · 9 comments

Comments

@edsko
Copy link
Contributor

edsko commented Oct 3, 2016

This might be what we want, but it might result in a lot of unnecessary candidate packages on Hackage; especially since the instructions say:

Package successfully uploaded as candidate. You can now preview the result at
'https://hackage.haskell.org/package/ghc-dump-tree-0.2.0.2/candidate'. To
publish the candidate, use 'cabal upload --publish'.

but don't explain how the candidate can be deleted (in fact, the wording suggests to me that --upload will delete the candidate, but it doesn't).

Perhaps a better UI might be cabal upload --publish versus cabal upload --candidate with either --publish or --candidate required.

Pinging @dcoutts and @hvr .

@hvr
Copy link
Member

hvr commented Oct 3, 2016

@edsko Well, there was the idea to have hackage automatically delete a candidate when its published or the exact same version uploaded, and then reject candidates being uploaded for which the very same version already exists published in the index.

IOW, candidates ought to be really just one of 3 states for a package version:

  • non-existing
  • candidate
  • published

@edsko
Copy link
Contributor Author

edsko commented Oct 3, 2016

Fair enough.

@23Skidoo
Copy link
Member

23Skidoo commented Oct 3, 2016

I think there's currently no way to delete a package candidate (except maybe via REST API?).

@edsko
Copy link
Contributor Author

edsko commented Oct 3, 2016

There is, although it took me a minute to find it as well. After you click on "Edit package information" you will be given an option to delete a candidate.

@23Skidoo
Copy link
Member

23Skidoo commented Oct 3, 2016

@ezyang
Copy link
Contributor

ezyang commented Oct 25, 2016

Can we close this bug?

@ezyang ezyang modified the milestones: 2.0, Triaged Oct 25, 2016
@23Skidoo
Copy link
Member

there was the idea to have hackage automatically delete a candidate when its published or the exact same version uploaded

Is there a hackage-server ticket for this feature?

@hvr
Copy link
Member

hvr commented Oct 26, 2016

@23Skidoo now there is... :-)

@23Skidoo
Copy link
Member

OK, closing in favour of haskell/hackage-server#558.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants