Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: library visibility enforcement #5806

Closed
fgaz opened this issue Dec 18, 2018 · 1 comment · Fixed by #5848
Closed

RFC: library visibility enforcement #5806

fgaz opened this issue Dec 18, 2018 · 1 comment · Fixed by #5848

Comments

@fgaz
Copy link
Member

fgaz commented Dec 18, 2018

So, before 3.0 we want a way to enforce library visibility, but to do that we need an extra field in IPI, which would require a GHC release and would restrict multilibs to GHC >=8.8.

Instead, what about:

  • enforcing visibility at the Cabal-the-lib level on GHC >=8.8 only
  • on GHC <8.8 just enforcing it at the cabal-install level
  • hoping that this doesn't happen

Update: we decided not to take the risk. Multilibs will only be supported from GHC 8.8

@fgaz fgaz added this to the 3.0 milestone Dec 18, 2018
@fgaz
Copy link
Member Author

fgaz commented Jun 10, 2019

#5848 does it. It also adds an override so cabal-install can add backward compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant