Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2-sdist does not create Setup.hs #5849

Open
eborden opened this issue Jan 18, 2019 · 6 comments
Open

v2-sdist does not create Setup.hs #5849

eborden opened this issue Jan 18, 2019 · 6 comments

Comments

@eborden
Copy link

eborden commented Jan 18, 2019

A project should not require a default Setup.hs. cabal v2-build works fine without one, but cabal v2-sdist fails to generate a default Setup.hs for the tarball.

Version

$ cabal --version
cabal-install version 2.4.1.0
compiled using version 2.4.1.0 of the Cabal library 

When uploaded to hackage

image

Source issue

see: haskell/network#357

@23Skidoo
Copy link
Member

Should be easy to fix. /cc @typedrat.

@hvr hvr added the type: bug label Jan 19, 2019
@hvr
Copy link
Member

hvr commented Jan 19, 2019

I can confirm that this is a regression relative to cabal v1-sdist (which does synthesize a Setup.hs on the fly)

@phadej
Copy link
Collaborator

phadej commented May 15, 2019

I was able to upload Setup.hs-less packages to Hackage...

@hvr
Copy link
Member

hvr commented May 15, 2019

To clarify, it appears that it's been possible at least since 2015 to upload Setup.hs-less packages (but only for build-type:Simple). And I can confirm that cabal-install 1.16 happily installs such packages without breaking a sweat. OP's package however doesn't fall into this category (due to build-type:Configure) which is why they got a validation error.

@23Skidoo
Copy link
Member

Hackage/cabal check should check that build-type: Configure packages have a Setup.hs or Setup.lhs.

@hvr
Copy link
Member

hvr commented May 16, 2019

@23Skidoo and it does :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants