Implement the setup executable cache. #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Significantly speeds up parallel builds.
|
Hi Mikhail, Thanks for the patch. I've added some comments. Could you please have a look at them? |
The function is very short and the name doesn't communicate clearly what it does.
|
Change looks good to me. Merged! |
|
Great! |
|
Hi guys, I've started to get some errors from this caching functionality and I didn't see an existing issue so I filed a new one here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements caching of the setup executables, which significantly speeds up parallel builds.
One potential issue is that the cache directory is unconditionally set to
~/.cabal/setup-exe-cache. When usingcabal-dev, perhaps we want the setup exe cache to live in the sandbox directory?