-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two AVL benchmarks fail with errors #47
Comments
I've commented those benchmarks out in #46 (adding Cabal benchmark integration), but they obviously need to be fixed. |
A brief glance suggests that the problem is in the implementation, rather than the benchmarks themselves. Uh-oh. |
This may have been caused by changes required for #14 (Though I can't see how as it would have failed before then as well, just with a different error.) |
Actually, I think I may have an idea about where the issues arise: Originally, But now, if a graph is empty the initial node created is So the question is to whether to fix this regression (that no-one has complained about, and indeed I couldn't find anyone actually using |
Yup, that fixed it. I'll give the changes to make in #46. |
We get
and
The text was updated successfully, but these errors were encountered: