Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for GHC < 8 #88

Closed
TeofilC opened this issue Jul 8, 2022 · 1 comment · Fixed by #89
Closed

Drop support for GHC < 8 #88

TeofilC opened this issue Jul 8, 2022 · 1 comment · Fixed by #89

Comments

@TeofilC
Copy link
Contributor

TeofilC commented Jul 8, 2022

My understanding is that this library has to work around incompatibilities between different encodings used by old versions of GHC.

I feel like dropping support for those old versions would help simplify the library and unblock some of the open issues.

I'm suggesting dropping compatibility with anything before GHC 8.0.1, which was released in May 2016. I think that's quite conservative but would still allow dropping all the special cases to deal with old GHCs afaict.
@Mikolaj
Copy link
Member

Mikolaj commented Jul 8, 2022

I think that's fair. Over 5 years of compatibility and people with ancient GHCs can use older versions of ghc-events.

@TeofilC TeofilC mentioned this issue Jul 9, 2022
Merged
@maoe maoe closed this as completed in #89 Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop support for GHC < 8 TeofilC/ghc-events
2 participants
@Mikolaj @TeofilC