Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

Way to Disable Brittany? #1064

Closed
Weizilla opened this issue Jan 26, 2019 · 5 comments
Closed

Way to Disable Brittany? #1064

Weizilla opened this issue Jan 26, 2019 · 5 comments

Comments

@Weizilla
Copy link

Is there a way to disable brittany? I would like to use a different formatter but I'm guessing that would be too difficult so I'm ok with disabling brittany in hie and just having my editor (VS Code) call a different formatter on save.

@Weizilla Weizilla changed the title Disable Brittany? Way to Disable Brittany? Jan 26, 2019
@lukel97
Copy link
Collaborator

lukel97 commented Jan 26, 2019

Does unselecting Format on Save in the VS Code settings disable the formatting for you?
image

@Weizilla
Copy link
Author

Ideally, I would like to use a different formatter but still have it execute on save and when using the Format Code editor command.

I thought maybe VS Code delegated everything to hie including the formatting so if I turned off brittany in hie, I could tell VS Code to use something else like hindent. Would that not work?

@Weizilla
Copy link
Author

There's an issue open with the VS Code HIE extension asking for the same thing: haskell/vscode-haskell#79

@lukel97
Copy link
Collaborator

lukel97 commented Jan 26, 2019

I think we could use the dynamic capability stuff to disable formatting with HIE, not sure if the internals support it yet.
We could also just add the other formatter into HIE ;)

@alanz
Copy link
Collaborator

alanz commented Jan 28, 2019

We could also just have a config flag that turns formatting requests into a NOP. And/or selects the specific formatter to use.

Realistically, formatting is one of those things that everyone has their own opinion on, so we need to expose as much flexibility as possible.

@alanz alanz added this to the 2019-02 milestone Feb 2, 2019
@lukel97 lukel97 closed this as completed Feb 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants