ghcide plugins don't honour generic plugin configuration

[jneira]

• The config was added with Introduce generic config for plugins #691
• As far i am able to test, ghcide plugins seems to ignore their sections
• With this config in .vscode/settings.json

{
    "haskell": {
        "plugin" : {
            "importLens" : {
                "codeLensOn" : false
            },
            "ghcide-type-lenses" : {
                "codeLensOn" : false
            }
        }
    }
}

i see import lenses are removed but no type sigs ones:

• I took plugin descriptors from https://github.com/haskell/haskell-language-server/blob/master/ghcide/src/Development/IDE/Plugin/HLS/GhcIde.hs#L20-L26, not sure if they are the correct way to use in the configuration

[berberman]

I think this issue was fixed by #1284:

haskell-language-server/hls-plugin-api/src/Ide/Types.hs

Line 73 in 4bcd0c6

pluginEnabled :: SMethod m -> PluginId -> Config -> Bool

[jneira]

So hls-1.0.0 should include it, could we test the configuration pasted above to confirm it (will do in some hours myself)?

[berberman]

Works for me

[jneira]

Many thanks for confirming it, love miss issues already resolved 😅