Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code actions get stuck occasionally in ghcide 0.7.4 #1348

Closed
pepeiborra opened this issue Feb 11, 2021 · 1 comment · Fixed by #1349
Closed

Code actions get stuck occasionally in ghcide 0.7.4 #1348

pepeiborra opened this issue Feb 11, 2021 · 1 comment · Fixed by #1349
Labels
component: ghcide type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@pepeiborra
Copy link
Collaborator

Steps to reproduce

Screen.Recording.2021-02-11.at.20.23.08.mov

Expected behaviour

ghcide should produce a code action

Actual behaviour

ghcide never sends a response for the code action request
@pepeiborra
Copy link
Collaborator Author

This is a regression, I believe it was introduced in #1316 where unsafePerformIO is used to lazily load the package exports. But what happens if the IO computation is interrupted asynchronously before it finishes?

@pepeiborra pepeiborra mentioned this issue Feb 11, 2021
Merged
@jneira jneira added component: ghcide type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. labels Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: ghcide type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix code actions regression haskell/haskell-language-server
2 participants
@pepeiborra @jneira