January release 1.6.0.0

[jneira]

The machine never stops! Time to plan the new release.

• will include two new brand plugins
• and the continuous work of @pepeiborra improving performance
• it will remove support for ghc-8.10.5
• it should include the artifacts from gitlab, hopefully in a automated way (see Add hls-1.5.1 ghcup-metadata#11 and Build on FreeBSD12 only #2420
• as noted by @hasufell the version of the gh release should match the hackage one (so 1.6.0.0)

as always if anyone feels strong enough to drive the release or collaborate with, help will be very welcomed 😺

---

prerelease sanity checks

• trigger manually the hackage workflow without uploading the packages: https://github.com/jneira/haskell-language-server/actions/runs/1751828521
• trigger manually the build workflow : https://github.com/jneira/haskell-language-server/actions/runs/1753316308
• create a prerelease tag 1.6.0-check-gitlab and push it to the project repo in gitlab to check the build is fine: https://gitlab.haskell.org/haskell/haskell-language-server/-/pipelines/46483

github release

• generate the list of pull requests finished since the last release using the haskell script in the project root.
  Nix users should run command gen-hls-changelogs (a wrapper of the script) in nix-shell instead.
• add that list to the actual Changelog with a description of the release.
• bump up versions of changed packages. All are optional but haskell-language-server itself.
• create the tag and make an initial prerelease to trigger the ci workflow (see details below)
• contact ghcup team (#haskell-ghcup irc channel or via its repo) to try to sync our release and its inclusion in ghcup
• in the github release edit page, check the attached binaries and the release description (usually the changelog entry) and uncheck the prerelease box
• make public the release in the usual social channels (not required but useful to spread the word 🙂):
  • irc
  • matrix
  • twitter
  • discord
  • discourse
  • reddit

hackage release

• bump up package versions following the pvp specification if they are not already updated. You could use policeman to help with this step.
• create 1.6.0-hackage branch to trigger the hackage github workflow which will upload all changed packages to hackage as candidates
• check manually candidates in hackage
• publish them definitely

ghcup release

• push the release tag to the haskell-language-server gitlab repo to trigger the build of ghcup specific artifacts
• download specific artifacts only available in the gitlab build and compute their sha256sum
• upload them to the github release and complete the SHA256SUMS file
• change ghcup metadata to include the new release in https://github.com/haskell/ghcup-metadata
  • example pull request here
  • pull request: Add hls-1.6.0.0 ghcup-metadata#19

[hasufell]

push the release tag to the haskell-language-server gitlab repo to trigger the build of ghcup specific artifacts
change ghcup metadata to include the new release in https://github.com/haskell/ghcup-metadata

Please do this before the release, otherwise ghcup will lack behind the release for several days again.

[pepeiborra]

Should we wait until all the pieces from #2357 have landed?

[Anton-Latukha]

Addressed the CI-side part of GHC-8.10.5 support removal in #2427

[jneira]

Should we wait until all the pieces from #2357 have landed?

Yeah no problem, i want to have the plan earlier this time but we can wait until mid month (i would like to do it before xmas holidays)

[jneira]

push the release tag to the haskell-language-server gitlab repo to trigger the build of ghcup specific artifacts
change ghcup metadata to include the new release in https://github.com/haskell/ghcup-metadata

Please do this before the release, otherwise ghcup will lack behind the release for several days again.

sure, we can push both tags at same time and keep the gh as a prerelase as long as we consider (last one was about one day as a prerelease)

[jneira]

Should we wait until all the pieces from #2357 have landed?

is there another pending pr related with?

[jneira]

Reopen to track final changes:

• tag created: https://github.com/haskell/haskell-language-server/tree/1.6.0.0
• prerrelase: https://github.com/haskell/haskell-language-server/releases/tag/1.6.0.0
• hackage build: https://github.com/haskell/haskell-language-server/actions/runs/1760982301
• release build: https://github.com/haskell/haskell-language-server/actions/runs/1760987798
• gitlab build: https://gitlab.haskell.org/haskell/haskell-language-server/-/pipelines/46645

[jneira]

The release build has failed for ubuntu 8.10.7 with:

<command line>: libtinfo.so.6: cannot open shared object file: No such file or directory
cabal: Failed to build ghcide-1.6.0.0 (which is required by exe:hls-wrapper
from hls-1.6.0.0).

I've reran the workflow deleting the already uploaded artifacts of the prerelease (as the workflow tries to upload them all and fails if an artifact with the same name is already attached to the release):https://github.com/haskell/haskell-language-server/actions/runs/1760987798

[hasufell]

The release build has failed for ubuntu 8.10.7 with:

<command line>: libtinfo.so.6: cannot open shared object file: No such file or directory
cabal: Failed to build ghcide-1.6.0.0 (which is required by exe:hls-wrapper
from hls-1.6.0.0).

I've reran the workflow deleting the already uploaded artifacts of the prerelease (as the workflow tries to upload them all and fails if an artifact with the same name is already attached to the release):https://github.com/haskell/haskell-language-server/actions/runs/1760987798

Which ubuntu version? Is ghcup used for installation?

[jneira]

Which ubuntu version? Is ghcup used for installation?

ubuntu-18.04 and using ghcup, yeah
i had seen that error before in a previous check build and rerunning fixed it

[jneira]

• The hackage workflow did not upload candidates
• It seems the input default value is not set if the workflow is triggered automatically via a branch instead a manual build, so i've reverted the condition with ad00c70 and triggered a new build: https://github.com/haskell/haskell-language-server/actions/runs/1761352874

[jneira]

All artifacts from the github build uploaded succesfully, we have to wait to gitlab one

[jneira]

The hackage workflow has uploaded all packages as candidates, they need be marked as definitive:

• hie-compat-0.2.1.1
• hls-graph-1.6.0.0
• shake-bench-0.1.0.3
• hls-plugin-api-1.3.0.0
• ghcide-1.6.0.0
• hls-test-utils-1.2.0.0
• hls-floskell-plugin-1.0.1.0
• hls-call-hierarchy-plugin-1.0.2.0
• hls-explicit-imports-plugin-1.0.2.0
• hls-ormolu-plugin-1.0.2.0
• hls-retrie-plugin-1.0.2.0
• hls-pragmas-plugin-1.0.2.0
• hls-qualify-imported-names-plugin-1.0.1.0: needs update hackage uploaders (add @eddiemundo and some other hls
• hls-alternate-number-format-plugin-1.0.1.0: needs update hackage uploaders (add @drsooch and some other hls maintainer)
• hls-stylish-haskell-plugin-1.0.1.0
• hls-refine-imports-plugin-1.0.1.0
• hls-splice-plugin-1.0.1.0
• hls-haddock-comments-plugin-1.0.1.0
• hls-brittany-plugin-1.0.2.0
• hls-class-plugin-1.0.2.0
• hls-tactics-plugin-1.6.0.0
• ls-hlint-plugin-1.0.3.0
• hls-eval-plugin-1.2.1.0
• hls-module-name-plugin-1.0.1.0
• hls-selection-range-plugin-1.0.0.0: needs update hackage uploaders (add @kokobd and some other hls maintainer)
• hls-fourmolu-plugin-1.0.2.0
• haskell-language-server-1.6.0.0

//cc @pepeiborra for hackage uploaders change, the hackage users for @kokobd, @eddiemundo and @drsooch would be needed, so please add them in a comment

[jneira]

• pr to add hls-1.6.0.0 to ghcup: Add hls-1.6.0.0 ghcup-metadata#19

[hasufell]

So... I don't understand why the alpine binaries are static when we know static binaries are busted and these can't be used for other linux distros either...

If you want to support alpine, you need to build dynamic binaries for it. GHC bindists are also dynamic for alpine.

[jneira]

• We did not get to publish specific binaries for alpine due a tar generation problem but afaik linux binaries are built the same way we did since the beginning. So they should work or be broken in the same way.

[jneira]

Made the release definitve! 🎆

[kokobd]

the hackage users for @kokobd, @eddiemundo and @drsooch would be needed, so please add them in a comment

@jneira @pepeiborra My hackage username is also kokobd. Is this what we need now? (not quite familiar with the hackage workflow)

[jneira]

yeah, we will add you to the plugin hackage maintainers and you will be able to upload, revise and all sort of things

[eddiemundo]

Oh didn't realize you meant we needed hackage accounts. In that case my username there is also eddiemundo.

[jneira]

Ok, the hackage release is also done: https://hackage.haskell.org/package/haskell-language-server-1.6.0.0 and @eddiemundo, @kokobd and @drsooch are hackage maintainers of their respective plugins, thanks to @pepeiborra
thanks all for helping in the release!