Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please, CI needs to run all plugins tests OR remind to add testsuite when new plugin is added #2531

Open
Anton-Latukha opened this issue Dec 23, 2021 · 2 comments
Labels
CI Continuous integration type: enhancement New feature or request

Comments

@Anton-Latukha
Copy link
Collaborator

Anton-Latukha commented Dec 23, 2021

In #2530 lead to: #2530 (comment)

On adding a new plugin - people on both sides of the review can forget (& CI would give a wrong impression that everything passes) that CI does not have plugin check. So CI actually does not check that the plugin works properly & contributor & reviewer can merge it.


  1. CI conf can be done in a way that it automatically runs/generates test suite runs forall plugins.
  2. When the new directory into plugins is added, or when the list of dirs there do not match the literal list - remind to add the test suite hook into `test.
@Anton-Latukha
Copy link
Collaborator Author

The easiest way every Haskeller would think looking into test.yml & would think to fmap over the list of plugins. In idiomatic GitHub (& in most of other CIs) terms that would be to matrix on plugins.

But there are ~15-20 plugins. GitHub invalidates/terminates CI workflow if matrix expands >256 instances (even if we deforest most of them right in the code - GitHub does not count deforestation).

So the solution should be default

@Anton-Latukha
Copy link
Collaborator Author

DHall would also allow solving this in the Haskell way.

@Anton-Latukha Anton-Latukha added the CI Continuous integration label Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants