Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Log of bugs] Folding range in hls-code-range-plugin #3294

Open
3 tasks
sloorush opened this issue Oct 17, 2022 · 1 comment
Open
3 tasks

[Log of bugs] Folding range in hls-code-range-plugin #3294

sloorush opened this issue Oct 17, 2022 · 1 comment
Labels
component: hls-code-range-plugin for code range related functionalities, such as selection range and folding range type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@sloorush
Copy link
Contributor

sloorush commented Oct 17, 2022

After adding the folding range feature in #3058, we found some minor bugs. If anyone has found any more bugs related to folding range, please note them down in this issue.

Here is the list of bugs/enhancements I could find:

  • blank lines in between declaration and function create lots of weird folding ranges

    Adding blank lines:

    image

    After folding any of the blank lines:

    image

    Problems:

    • Empty lines should not be folding range starts
    • Blank lines between the function should not fold
  • Deleting lines retains old folding ranges for some time till it refreshes

    image

    Problems:

    • It should show correct folding ranges or no folding ranges till new folding ranges can be found
  • Folding range does not interact with comments

    Problems:

@michaelpj @kokobd Did you come across any other issues with folding ranges?

@sloorush sloorush added status: needs triage type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. labels Oct 17, 2022
@kokobd
Copy link
Collaborator

kokobd commented Oct 17, 2022

@sloorush Thank you! Maybe we could extend #3005 to mention folding ranges too. And do note that introducing exact print in code range will break it on ghc-9.4, as retrie hasn't been patched for 9.4.

PS: I'm spending less time on HLS these weeks, and I'm still working on 9.2 support of haddock comments plugin, slowly. So feel free to pick up one of the issues of code range plugin, if you want ;)

@kokobd kokobd added component: hls-code-range-plugin for code range related functionalities, such as selection range and folding range and removed status: needs triage labels Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: hls-code-range-plugin for code range related functionalities, such as selection range and folding range type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Development

No branches or pull requests

2 participants