Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot rename implicit parameters #3416

Open
aavogt opened this issue Dec 20, 2022 · 0 comments
Open

cannot rename implicit parameters #3416

aavogt opened this issue Dec 20, 2022 · 0 comments
Assignees
Labels
component: hls-rename-plugin type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@aavogt
Copy link

aavogt commented Dec 20, 2022

If my cursor is over ?x in the file below, a prompt can come up to rename x, but it doesn't change the file. I use hls 1.8

{-# LANGUAGE ImplicitParams #-}
a = let ?x = 3 in ?x

If you select a single ?x to rename to ?y, I see two options:

aa = (let ?x = 3 in ?x, let ?x = 2 in ?x) -- original
aa = (let ?y = 3 in ?y, let ?x = 2 in ?x) -- scoped rename
aa = (let ?y = 3 in ?y, let ?y = 2 in ?y) -- global rename

I would prefer "Scoped" for consistency with regular variables.

@aavogt aavogt added status: needs triage type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. labels Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: hls-rename-plugin type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Development

No branches or pull requests

3 participants