Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration for how much of the project to build #3873

Open
michaelpj opened this issue Nov 15, 2023 · 5 comments
Open

Configuration for how much of the project to build #3873

michaelpj opened this issue Nov 15, 2023 · 5 comments
Labels
type: enhancement New feature or request

Comments

@michaelpj
Copy link
Collaborator

At the moment, HLS builds only the files that are open in the editor by default (and their dependencies). We have the checkProject option, which instead builds all the files in the current component.

Especially once proper multi-component support is finished, it seems to me that there are actually several levels of aggressiveness that you might want.

  1. Build only the files open in the editor
  2. Build all the files in the current component
  3. Build all the files in all the components in the current package
  4. Build all the files in all the components in all the packages in the project

So I wonder if we should replace checkProject with a new option (buildAggressiveness?) with four alternatives:

  1. open-files
  2. current-component
  3. current-package
  4. all-packages
@Anrock
Copy link
Contributor

Anrock commented Nov 16, 2023

Would it be possible to have sort of incremental option where HLS first build open-files then if everything is ok, builds current-component and so on until everything is built?

@michaelpj
Copy link
Collaborator Author

I'm unsure if that makes sense based on how HLS works 🤔

@soulomoon
Copy link
Collaborator

soulomoon commented Jan 16, 2024

Would it be possible to have sort of incremental option where HLS first build open-files then if everything is ok, builds current-component and so on until everything is built?

I think it already is, HLS keeps files of interest (which are open-files) in shake. And doing build related to FOI.

@michaelpj
Copy link
Collaborator Author

I think that's just describing the open-files strategy: FOIs more-or-less correspond to open files. We don't then go on to build the rest of the project or anything.

@michaelpj
Copy link
Collaborator Author

Just to add a few more thoughts: while in some ways "load everything in the project" is probably the most intuitive thing for users, I think we need it to be configurable because for people (often in industry) with very large projects this may just eat all their memory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants