Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HLS source distribution is missing extra-source-files necessary for testing #4104

Open
fendor opened this issue Feb 29, 2024 · 3 comments
Open

HLS source distribution is missing extra-source-files necessary for testing #4104

fendor opened this issue Feb 29, 2024 · 3 comments
Labels
Hackage Anything to do with Hackage distributions of HLS type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@fendor
Copy link
Collaborator

fendor commented Feb 29, 2024 •
edited

image

Vs:

> ls plugins/hls-semantic-tokens-plugin/test/testdata/ | wc -l
52

In particular, we are missing all *.expected files. We should test that we can run the tests of the source distribution produced by cabal sdist.
@fendor fendor added type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. status: needs triage labels Feb 29, 2024
@fendor
Copy link
Collaborator Author

fendor commented Feb 29, 2024

Closed by #4105

@fendor
Copy link
Collaborator Author

fendor commented Mar 3, 2024

We fixed this situation in #4105 and #4107, but we should add a CI check that this can't happen again. Potentially, the workflow for running tests should be as follows: cabal sdist > tar > cabal test. Iirc, haskell-ci generates this workflow.

@fendor fendor changed the title cabal sdist is missing many extra-source-files HLS source distribution is missing extra-source-files necessary for testing Mar 3, 2024
@fendor fendor added Hackage Anything to do with Hackage distributions of HLS and removed status: needs triage labels Mar 6, 2024
@michaelpj
Copy link
Collaborator

Relevant: haskell/cabal#1141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Hackage Anything to do with Hackage distributions of HLS type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelpj @fendor