Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider a onVFSChange callback #555

Open
michaelpj opened this issue Feb 7, 2024 · 0 comments
Open

Consider a onVFSChange callback #555

michaelpj opened this issue Feb 7, 2024 · 0 comments

Comments

@michaelpj
Copy link
Collaborator

At the moment, if a server wants to react to document changes, it has to add its own handlers for the various document change notifications. This is somewhat repetitious, and anyway lsp is managing these inside the VFS for you.

Contrast with what we do for config changes, where we abstract this away and just offer an onConfigChange callback. This is necessitated because config state changes are not always triggered by a notification, but perhaps the general principle is good.

Hence I think maybe we want to offer some kind of onVFSChange callback which might offer a more straightforward interface for common usecases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

1 participant