-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export URI parser #56
Comments
I think that's reasonable. My only hesitation would be, it exposes the "implementation detail" of which parser-combinator library we happen to use (Parsec at the moment). That said, the library has been so stable for so long, I doubt we would ever change the combinator library. I'll work something up that we can talk about. |
@ocharles if you have any sample code where you'd like to use these combinators, I'd be interested to see it, to appreciate the need this is filling. Also see the above pull request and let me know what you think. |
I actually have ended up hand-rolling a parser now, and having the So tl;dr, I no longer actually need this. I still think it would be worthwhile to export, but can also appreciate not wanting to increase the surface area of the API. Shall I close this issue, or leave it open? |
OK, that makes sense. I'm willing to consider exporting the parser, but in the absence of more people saying they'd like to see it, I'll remain cautious for now. And, perhaps we'll leave the issue open for now in case others want to voice their interest. Sound good? |
Perfect! |
The library exports
String -> Maybe URI
functions, but this is not easy to compose with other parsers. For example, I'm writing a tokeniser that needs to identify URIs and a bunch of other stuff. I have to do some tedious gymnastics to fitparseURI
in, but if I had access to the actualParser
itself, it would be much easier.The text was updated successfully, but these errors were encountered: