Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releasing 3.1.1.0 #421

Closed
kazu-yamamoto opened this issue Aug 28, 2019 · 11 comments
Closed

Releasing 3.1.1.0 #421

kazu-yamamoto opened this issue Aug 28, 2019 · 11 comments
Assignees

Comments

@kazu-yamamoto
Copy link
Collaborator

gracefulClose has been merged. I would like to release a new version. Should we wait for #418?

@eborden
Copy link
Collaborator

eborden commented Sep 3, 2019

Oh hey, sorry. I came back from vacation, then left again for another vacation. I've got this on my todo list for this week. Awesome work on gracefulClose.

@kazu-yamamoto
Copy link
Collaborator Author

We are tackling #424 which should be included in 3.1.1.0.
So, I should wait for your return of the next vacation.
Would you tell me when you will come back?

@eborden
Copy link
Collaborator

eborden commented Sep 3, 2019

@kazu-yamamoto I am back now. I won't release till #424 is merged.

@kazu-yamamoto
Copy link
Collaborator Author

Oh. I understand what you meant!

@kazu-yamamoto
Copy link
Collaborator Author

@eborden We are ready for releasing this version.

Cc: @Mistuke

@eborden
Copy link
Collaborator

eborden commented Sep 19, 2019

Taking a look at this now.

@eborden
Copy link
Collaborator

eborden commented Sep 19, 2019

Here is a release candidate.

http://hackage.haskell.org/package/network-3.1.1.0/candidate

I made a few additions to the changelog. Let me know if you see anything missing.

## Version 3.1.1.0

* A new API: `gracefulClose`.
  [#417](https://github.com/haskell/network/pull/417)
* `touchSocket`, `unsafeFdSocket`: Allow direct access to a socket's file
  descriptor while providing tools to prevent it from being garbage collected.
  This also deprecated `fdSocket` in favor of `unsafeFdSocket` and
  `withFdSocket`.
  [#423](https://github.com/haskell/network/pull/423)
* `socketToFd`: Duplicates a socket as a file desriptor and closes the source
  socket.
  [#424](https://github.com/haskell/network/pull/424)

@kazu-yamamoto
Copy link
Collaborator Author

Looks good. Please go ahead!

@kazu-yamamoto
Copy link
Collaborator Author

@eborden Ping

@eborden
Copy link
Collaborator

eborden commented Sep 23, 2019

Candidate is published and cafe message is sent (with a plug for your blog post).

@eborden eborden closed this as completed Sep 23, 2019
@kazu-yamamoto
Copy link
Collaborator Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants