You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Replacing the implementation with the following suboptimal one can serve as a quick fix for the time being:
flushTBQueue::TBQueuea->STM [a]
flushTBQueue queue =
go []where
go !acc =do
element <- tryReadTBQueue queue
case element ofJust element -> go $ element : acc
Nothing->return$reverse acc
I guess the bug was introduced in #70. So @konsumlamm please take a look.
We need stricter quality assurance standards for this package. Bugs in packages as central as this can have very dire impact on the stability of the whole ecosystem and the reputation of the language. There's 13496 indirect dependencies just on Hackage, meaning that virtually any application can get affected by bugs in this package. Another issue is that people don't expect bugs from such central packages, e.g., I've lost quite some time debugging this simply because I could not believe that the bug would come from "stm".
I suggest that rewrites should be done with extreme caution and should be exhaustively covered with tests. As I see #70 came with 0 tests.
The text was updated successfully, but these errors were encountered:
Here's an idea on how the new implementation can be tested. The old implementation can be copied to a test suite which will generate random actions and execute them on both implementations and compare the results. Thus we can ensure that the new implementation behaves the same as the old one.
It acts weirdly. Causes random halts and etc.
One issue that is easily reproducible is that the following test fails:
Replacing the implementation with the following suboptimal one can serve as a quick fix for the time being:
I guess the bug was introduced in #70. So @konsumlamm please take a look.
@bgamari @simonmar @hvr
We need stricter quality assurance standards for this package. Bugs in packages as central as this can have very dire impact on the stability of the whole ecosystem and the reputation of the language. There's 13496 indirect dependencies just on Hackage, meaning that virtually any application can get affected by bugs in this package. Another issue is that people don't expect bugs from such central packages, e.g., I've lost quite some time debugging this simply because I could not believe that the bug would come from "stm".
I suggest that rewrites should be done with extreme caution and should be exhaustively covered with tests. As I see #70 came with 0 tests.
The text was updated successfully, but these errors were encountered: