Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Off by one in writeBlocksRaw #587

Open
BebeSparkelSparkel opened this issue Apr 28, 2024 · 0 comments · May be fixed by #590
Open

Off by one in writeBlocksRaw #587

BebeSparkelSparkel opened this issue Apr 28, 2024 · 0 comments · May be fixed by #590

Comments

@BebeSparkelSparkel
Copy link
Contributor

writeBlocksRaw uses the same bounds check as writeBlocksCRLF. writeBlocksRaw will always only write one character while writeBlocksCRLF can write two.

Seems like it should actually be

          | n >= len -> commit n True{-needs flush-} False >>= outer s
@BebeSparkelSparkel BebeSparkelSparkel linked a pull request Apr 28, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed off by one for writeBlocksRaw BebeSparkelSparkel/text
1 participant
@BebeSparkelSparkel