Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nowhere seems to export the constructor to Storable vector #343

Closed
Boarders opened this issue Dec 22, 2020 · 4 comments
Closed

Nowhere seems to export the constructor to Storable vector #343

Boarders opened this issue Dec 22, 2020 · 4 comments

Comments

@Boarders
Copy link
Contributor

It would be nice if the internal module exported everything in the various modules and made no guarantees with regards to stability.

@Boarders
Copy link
Contributor Author

More generally could we please move towards vector exporting everything somewhere. As it stands a user is not allowed to touch almost any aspect of the stream fusion framework. There is no particularly good reason for this if the relevant modules are marked unsafe and unstable.

@lehins
Copy link
Contributor

lehins commented Dec 22, 2020

You can already get to the internals of storable vector with unsafe to/from ForeignPtr convertors:

Same applies to mutable vector

@Boarders
Copy link
Contributor Author

I know, but if I want to copy and edit some internal vector code for doing streaming I am forced to jump through so many hoops like this and it seems completely needless.

@lehins
Copy link
Contributor

lehins commented Dec 22, 2020

could we please move towards vector exporting everything somewhere.

Could you be more specific? Almost every aspect is already exported, including the stream fusion functionality. Maybe not as directly as it seems, but it is totally usable. In other words, could you compile a list of things you'd like to get access to that aren't available right now and we should be able to get them exported from some special module. Without such list we can't do anything because "export everything" blindly is too messy of an approach, some things are really designed to be internal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants