Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hls-class-plugin setting fields are missing #686

Closed
July541 opened this issue Aug 15, 2022 · 6 comments
Closed

hls-class-plugin setting fields are missing #686

July541 opened this issue Aug 15, 2022 · 6 comments
Labels
type: bug A bug or unintended effect

Comments

@July541
Copy link
Collaborator

July541 commented Aug 15, 2022

After haskell/haskell-language-server#2920, hls-class-plugin has two configurable fields now(after haskell/haskell-language-server#3107), including:

  1. haskell.plugin.class.codeActionsOn
  2. haskell.plugin.class.codeLensOn

But currently vscode-haskell only has the first one.

@fendor fendor added type: bug A bug or unintended effect and removed status: needs triage labels Aug 15, 2022
@fendor
Copy link
Collaborator

fendor commented Aug 15, 2022

Weird, must have slipped through :(

@July541
Copy link
Collaborator Author

July541 commented Aug 15, 2022

My fault, I should raise an issue here after haskell/haskell-language-server#2920. But the pr takes so much time, I forgot it...

@July541
Copy link
Collaborator Author

July541 commented Aug 15, 2022

BTW, will you update the fields by scanning the pr list in hls or rely on haskell-language-server generate-default-config?

@fendor
Copy link
Collaborator

fendor commented Aug 15, 2022

I rely on haskell-language-server vscode-extension-schema which I copy-paste into package.json. More automation would be welcome, so far I couldn't find any existing infrastructure for doing it automatically.

However, I am currently working on printing the json with sorted keys, making sure we haven't deleted anything on accident and making it easier to view added keys.

@fendor
Copy link
Collaborator

fendor commented Dec 5, 2022

I think this will be fixed in #773, @July541 could you make sure the current version of package.json contains all the hls-class-plugin options it should contain?

@fendor fendor closed this as completed Dec 5, 2022
@fendor fendor reopened this Dec 5, 2022
@July541
Copy link
Collaborator Author

July541 commented Dec 5, 2022

Looks reasonable to me, and I confirmed

{
    "haskell.plugin.class.codeLensOn": false,
    "haskell.plugin.class.codeActionsOn": false
}

works for me.

Let's go!

@July541 July541 closed this as completed Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A bug or unintended effect
Projects
None yet
Development

No branches or pull requests

2 participants