Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a few tool-version-related hiccups during installation #556

Open
TomLippincott opened this issue May 21, 2021 · 2 comments
Open

a few tool-version-related hiccups during installation #556

TomLippincott opened this issue May 21, 2021 · 2 comments

Comments

@TomLippincott
Copy link

Just wanted to point out a few unchecked version-bounds that make the installation process a little tricky:

  • git needs to be at least >=1.8.4 for the get-deps.sh script to work (or the git submodule invocation should happen at the top of the file tree)
  • GCC needs to be >= 5 to compile (I think because it requires c++14): in some situations the build points this out, but in others it reports syntax errors and a need for c++11, and only after fiddling with the cabal files did it inform that GCC 4 (which is still used by centos 7) is a non-starter
  • Debian, for one, no longer has a plain "python" command, only python2/python3, and the userspace solution of building from within a venv doesn't work because there's no notion there of a "user"-install. The simplest approach might be to test for an appropriate interpreter, falling back from python->python3->python2, but the clean approach IMO would be to also create and use a venv so packages don't get installed to the user's general library-space.
@junjihashimoto
Copy link
Member

@TomLippincott
Thank you for your pointing out these bounds.
I think it's better to include these things in the README.
What do you think?

@TomLippincott
Copy link
Author

Some of them maybe, but the scripts could do a bit more in checking versions and alternative executable names. I'm not up-to-date on best practices for bullet-proofing this sort of heterogeneous build, I seem to remember autoconf/automake as the standard approach for checking dependencies like compiler and interpreter versions.

I'm hoping when I reach a stable point in what I'm working on to be able to help address some of these things, I don't really expect/want the core developers to drop what they're doing because the more fundamental progress of this library is what's truly impressive!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants