Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rar2fs-1.15.0 fails to build against headers/library from upstream release of unrar-4.2.1 #10

Closed
hasse69 opened this issue Mar 13, 2015 · 8 comments

Comments

@hasse69
Copy link
Owner

hasse69 commented Mar 13, 2015

What steps will reproduce the problem?
1. Install unrar-4.2.1 with the libunrar and headers and point rar2fs to them.
2. Try to build rar2fs-1.15.0.

What do you see instead?

checking rar.hpp usability... yes
checking rar.hpp presence... yes
checking for rar.hpp... yes
checking for RARGetDllVersion in -lunrar... yes
checking for source revision in SVN... no
checking for sched_setaffinity... yes
checking whether cpu_set_t available... yes
checking whether the CPU_SET and CPU_ZERO macros are defined... yes
checking scandir ARG3 => const struct dirent * ... ok
checking if compiler supports -fno-omit-frame-pointer... yes
checking if compiler supports -Wno-unused-result... yes
checking if linker supports -rdynamic... yes
configure: creating ./config.status
config.status: creating Makefile
config.status: creating config.h
config.status: executing depfiles commands
>>> Source configured.
>>> Compiling source in /var/tmp/portage/sys-fs/rar2fs-1.15.0/work/rar2fs-1.15.0 ...
make -j9 
make  all-am
make[1]: Entering directory `/var/tmp/portage/sys-fs/rar2fs-1.15.0/work/rar2fs-1.15.0'
x86_64-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I.  -I/usr/include/libunrar -D_FILE_OFFSET_BITS=64 -DFUSE_USE_VERSION=26 -DNDEBUG -DRARDLL -Wall  -march=native -O2 -pipe -pthread -c -o dllext.o dllext.cpp
x86_64-pc-linux-gnu-gcc -std=gnu99 -DHAVE_CONFIG_H -I.  -I/usr/include/libunrar -D_FILE_OFFSET_BITS=64 -DFUSE_USE_VERSION=26 -DNDEBUG -Wall -march=native -O2 -pipe -fno-omit-frame-pointer -Wno-unused-result -pthread -c configdb.c
x86_64-pc-linux-gnu-gcc -std=gnu99 -DHAVE_CONFIG_H -I.  -I/usr/include/libunrar -D_FILE_OFFSET_BITS=64 -DFUSE_USE_VERSION=26 -DNDEBUG -Wall -march=native -O2 -pipe -fno-omit-frame-pointer -Wno-unused-result -pthread -c filecache.c
x86_64-pc-linux-gnu-gcc -std=gnu99 -DHAVE_CONFIG_H -I.  -I/usr/include/libunrar -D_FILE_OFFSET_BITS=64 -DFUSE_USE_VERSION=26 -DNDEBUG -Wall -march=native -O2 -pipe -fno-omit-frame-pointer -Wno-unused-result -pthread -c iobuffer.c
x86_64-pc-linux-gnu-gcc -std=gnu99 -DHAVE_CONFIG_H -I.  -I/usr/include/libunrar -D_FILE_OFFSET_BITS=64 -DFUSE_USE_VERSION=26 -DNDEBUG -Wall -march=native -O2 -pipe -fno-omit-frame-pointer -Wno-unused-result -pthread -c sighandler.c
x86_64-pc-linux-gnu-gcc -std=gnu99 -DHAVE_CONFIG_H -I.  -I/usr/include/libunrar -D_FILE_OFFSET_BITS=64 -DFUSE_USE_VERSION=26 -DNDEBUG -Wall -march=native -O2 -pipe -fno-omit-frame-pointer -Wno-unused-result -pthread -c dirlist.c
x86_64-pc-linux-gnu-gcc -std=gnu99 -DHAVE_CONFIG_H -I.  -I/usr/include/libunrar -D_FILE_OFFSET_BITS=64 -DFUSE_USE_VERSION=26 -DNDEBUG -Wall -march=native -O2 -pipe -fno-omit-frame-pointer -Wno-unused-result -pthread -c rar2fs.c
x86_64-pc-linux-gnu-gcc -std=gnu99 -DHAVE_CONFIG_H -I.  -I/usr/include/libunrar -D_FILE_OFFSET_BITS=64 -DFUSE_USE_VERSION=26 -DNDEBUG -Wall -march=native -O2 -pipe -fno-omit-frame-pointer -Wno-unused-result -pthread -c mkr2i.c
x86_64-pc-linux-gnu-gcc -std=gnu99 -o mkr2i mkr2i.o -Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu -rdynamic     
dllext.cpp: In function ‘int RarErrorToDll(int)’:
dllext.cpp:246:12: error: ‘FATAL_ERROR’ was not declared in this scope
dllext.cpp:248:12: error: ‘CRC_ERROR’ was not declared in this scope
dllext.cpp:250:12: error: ‘WRITE_ERROR’ was not declared in this scope
dllext.cpp:252:12: error: ‘OPEN_ERROR’ was not declared in this scope
dllext.cpp:254:12: error: ‘CREATE_ERROR’ was not declared in this scope
dllext.cpp:256:12: error: ‘MEMORY_ERROR’ was not declared in this scope
dllext.cpp:258:12: error: ‘SUCCESS’ was not declared in this scope
make[1]: *** [dllext.o] Error 1

<b>What version of the product are you using? On what operating system?</b>

Linux, gcc-4.6.x, glibc-2.15.x, Gentoo (I'm the maintainer for unrar and rar2fs in Gentoo just if you are intrested in knowing ;-)

Original issue reported on code.google.com by ssuominen.private on 2012-05-05

@hasse69 hasse69 self-assigned this Mar 13, 2015
@hasse69 hasse69 closed this as completed Mar 13, 2015
@hasse69 hasse69 removed their assignment Mar 13, 2015
@hasse69
Copy link
Owner Author

hasse69 commented May 23, 2015

Same problem with release of 1.14.0, but downgrading unrar to 4.1.4 seems to "help",
but obviously this is not the solution

Original issue reported on code.google.com by ssuominen.private on 2012-05-05 12:33:20

@hasse69
Copy link
Owner Author

hasse69 commented May 23, 2015

Thanks for the report. UnRAR source 4.2.1 was released very recently, after the release
of rar2fs 1.15.0. I have not had a chance to test it yet. Will look into this issue
as soon as possible.

Original issue reported on code.google.com by hans.beckerus on 2012-05-05 14:51:49

@hasse69
Copy link
Owner Author

hasse69 commented May 23, 2015

(No text was entered with this change)

Original issue reported on code.google.com by hans.beckerus on 2012-05-05 15:39:09

@hasse69
Copy link
Owner Author

hasse69 commented May 23, 2015

Looking through the source of unrar 4.2.1, it seems the error macros changed from the
*_ERROR style to RARX_*  (such as RARX_USERERROR as opposed to USER_ERROR)

Original issue reported on code.google.com by jdhore1 on 2012-05-05 17:36:35

@hasse69
Copy link
Owner Author

hasse69 commented May 23, 2015

Yes, seems backward compatibility was broken by this new release of the UnRAR source.
I will create a patch release version of rar2fs that should take care of it.

Original issue reported on code.google.com by hans.beckerus on 2012-05-06 08:56:11

@hasse69
Copy link
Owner Author

hasse69 commented May 23, 2015

There is now a new patch release available that resolves this issue.

Original issue reported on code.google.com by hans.beckerus on 2012-05-06 12:24:06

@hasse69
Copy link
Owner Author

hasse69 commented May 23, 2015

1.15.1 works for me (based on minimal testing). Thanks!

Original issue reported on code.google.com by ssuominen.private on 2012-05-07 11:12:54

@hasse69
Copy link
Owner Author

hasse69 commented May 23, 2015

Nice to hear that the issue could be resolved and tested quickly.
Case closed.

Original issue reported on code.google.com by hans.beckerus on 2012-05-07 11:30:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant