Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable new push notifications functionality #278

Closed
Dakael opened this issue Sep 14, 2023 · 1 comment
Closed

Enable new push notifications functionality #278

Dakael opened this issue Sep 14, 2023 · 1 comment

Comments

@Dakael
Copy link

Dakael commented Sep 14, 2023

Problem/Motivation

Now that vaultwarden supports push notifications for syncing mobile bitwarden clients, we need to be able to pass the following environment variables to the addon container enable it.

PUSH_ENABLED=true
PUSH_INSTALLATION_ID=CHANGEME
PUSH_INSTALLATION_KEY=CHANGEME

Unfortunately this cannot be done through the admin page, as the three relevant fields are in the Read Only Config section.

image

Proposed changes

Ideally, add the three as options in the addon configuration screen in home assistant.

@frenck
Copy link
Member

frenck commented Sep 14, 2023

Ideally, add the three as options in the addon configuration screen in home assistant.

That is a hard "no" for me. I suggest opening up a feature request upstream to get it added to the admin page. As all other configuration is there, putting these there makes much more sense as well.

../Frenck

@hassio-addons hassio-addons locked and limited conversation to collaborators Sep 14, 2023
@frenck frenck converted this issue into discussion #279 Sep 14, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants