Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config Enabling Mobile Client push notification #283

Closed
svenrobbie opened this issue Oct 9, 2023 · 3 comments
Closed

Config Enabling Mobile Client push notification #283

svenrobbie opened this issue Oct 9, 2023 · 3 comments

Comments

@svenrobbie
Copy link

Problem/Motivation

Config Enabling Mobile Client push notification

Expected behavior

Enable Mobile Client push notification in config file and have it auto sync.

Actual behavior

It's not possible to enable the Mobile Client push notification true a change in the config file. if this is done true the config Supervisor
gives an error.

Steps to reproduce

Add: environment:
- PUSH_ENABLED=true
- PUSH_INSTALLATION_ID=
- PUSH_INSTALLATION_KEY=

to config.

Proposed changes

Add the Enabling Mobile Client push notification function as a config file option.

@frenck
Copy link
Member

frenck commented Oct 9, 2023

This can be set in the admin page of vaultwarden, right?

I'm not sure why we should add environment variables for that?

../Frenck

@svenrobbie
Copy link
Author

Nope, it's in the read-only section of the config....

@frenck
Copy link
Member

frenck commented Oct 9, 2023

In that case, please open a feature request with Vaultwarden. I'm not planning on adding features to set env variables. I think it is really confusing to have multiple ways to handle things.

../Frenck

@frenck frenck closed this as not planned Won't fix, can't repro, duplicate, stale Oct 9, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants